keywording for arm64

Khumarahn · Apprentice Joined: 17 Apr 2009 Posts: 199

Hi,

I have been running gentoo on an arm64 laptop, and had to install quite a number of packages without arm64 or ~arm64 keywords, see the list below.

I think that most of these should be keyworded at least ~arm64. What is the right way to approach this?

EDIT: list below shows relevant github PR and marks those already completed

Khumarahn · Apprentice Joined: 17 Apr 2009 Posts: 199

The script to find installed packages without arm64 keywords:

mDup · Apprentice Joined: 14 Apr 2006 Posts: 212

Khumarahn · Apprentice Joined: 17 Apr 2009 Posts: 199

I do ACCEPT_KEYWORDS="arm ~arm64 amd64 ~amd64"
:-)

So the question is how to approach the mass keywording. I could create a PR on github, or a bug in the bugzilla... Does this have to be many PRs or bugs, or just one? There is the equal visibility requirement, so keywordings need to be related. What is the least painful way to do this?

mDup · Apprentice Joined: 14 Apr 2006 Posts: 212

NeddySeagoon · Posted: Fri Mar 30, 2018 6:05 pm Post subject:

Khumarahn,

edit to add text in italics.

Create one PR per logical change to the tree not per package emerged.
A logical change being a top level package and all of its dependencies.

e.g.

Khumarahn · Apprentice Joined: 17 Apr 2009 Posts: 199

Thanks for the advice!

Here goes the PR for kicad:
https://github.com/gentoo/gentoo/pull/7737

Khumarahn · Apprentice Joined: 17 Apr 2009 Posts: 199

Added a PR for haveged:
https://github.com/gentoo/gentoo/pull/7738

I will edit the first post with the links for the corresponding PR. I will submit a few PR today and we'll see how it goes.

EDIT: I created 7 PR. Will wait now to see how it goes.

blopsalot · Apprentice Joined: 28 Jan 2017 Posts: 231

Khumarahn, thank you!

I hope it's not ignored, create one bug report on bugzilla to increase visibility and add the bug to your PRs so the bot picks it up like this:
https://wiki.gentoo.org/wiki/Gentoo_GitHub#Links_to_bug_report.28s.29

NeddySeagoon · Posted: Sat Mar 31, 2018 3:46 pm Post subject:

blopsalot,

It won't be ignored. I run ~arm64 on a Raspberry Pi3.
Using a 32 bit install would be like keeping a Ferrari just to drive to the corner shop.
_________________
Regards,

NeddySeagoon

Computer users fall into two groups:-
those that do backups
those that have never had a hard drive fail.

Khumarahn · Apprentice Joined: 17 Apr 2009 Posts: 199

So far, things are smooth. I created 16 pull requests, 4 got merged almost instantaneously. Details are in the first post.

@blopsalot, I thought I probably should create a bug, bug got lazy. Certainly would try to avoid creating bugs for each package :-)

NeddySeagoon · Posted: Sat Mar 31, 2018 6:28 pm Post subject:

Khumarahn,

Some devs watch for PRs, some don't
Some of my PRs have taken weeks.

Gentoo is an all volunteer distro, so real life always comes first.
_________________
Regards,

NeddySeagoon

Computer users fall into two groups:-
those that do backups
those that have never had a hard drive fail.

Khumarahn · Apprentice Joined: 17 Apr 2009 Posts: 199

All 16 out of 16 pull requests are merged. Very fast :-)

The developers complain that many small pull requests "apparently kills the CI checks into a huge backlog". I will need to do the rest in a few larger pull requests. Which is also easier for me.