View previous topic :: View next topic |
Author |
Message |
Zucca Moderator
Joined: 14 Jun 2007 Posts: 3826 Location: Rasi, Finland
|
Posted: Thu Jan 02, 2025 4:09 pm Post subject: lsp - The least significant pager |
|
|
Hi.
I decided to start a general support/tip topic about app-text/lsp.
I have version 0.5.0_rc4, and whatever I do I get Code: | lsp_init_screen: Could not change color. | ... error message. Even if I supply --no-colors switch.
I invited lsp maintainer here also, so we can iron out the bugs. :) _________________ ..: Zucca :..
My gentoo installs: | init=/sbin/openrc-init
-systemd -logind -elogind seatd |
Quote: | I am NaN! I am a man! |
|
|
Back to top |
|
|
dgouders n00b
Joined: 29 Jan 2024 Posts: 9
|
Posted: Thu Jan 02, 2025 9:46 pm Post subject: |
|
|
Thank you for starting this topic and of course for spending your time to look at lsp.
This triggers me to update the ebuild to a more recent commit within the next days.
Concerning the error you triggered:
I think I should use can_change_color() before trying to change colors; thanks for telling me
that the foot teminal emulator triggers this problem so I can use it to test all that. |
|
Back to top |
|
|
Zucca Moderator
Joined: 14 Jun 2007 Posts: 3826 Location: Rasi, Finland
|
Posted: Thu Jan 02, 2025 10:39 pm Post subject: |
|
|
If you can get the live/9999 version of lsp on ::guru, I could act as your guinea pig. ;D
Although, I could also just create one on my own overlay. _________________ ..: Zucca :..
My gentoo installs: | init=/sbin/openrc-init
-systemd -logind -elogind seatd |
Quote: | I am NaN! I am a man! |
|
|
Back to top |
|
|
Zucca Moderator
Joined: 14 Jun 2007 Posts: 3826 Location: Rasi, Finland
|
Posted: Fri Jan 03, 2025 9:41 am Post subject: |
|
|
I did few tests: Code: | $ env -i - TERM=xterm lsp README.adoc
lsp_init_screen: Could not change color. |
Code: | env -i - TERM=xterm-256color lsp README.adoc |
_________________ ..: Zucca :..
My gentoo installs: | init=/sbin/openrc-init
-systemd -logind -elogind seatd |
Quote: | I am NaN! I am a man! |
|
|
Back to top |
|
|
dgouders n00b
Joined: 29 Jan 2024 Posts: 9
|
Posted: Fri Jan 03, 2025 8:04 pm Post subject: |
|
|
Today, I spent some time to do some cleanup and push several commits that I didn't push
for a longer period; now, github is in sync with my local stuff.
Next, I will create a 9999 ebuild as you suggested.
Thanks for "waking me up" so that I re-focus to real problems
Thanks for the tests that helped me to analyze the color-problem
I'm now going to commit two fixes (I guess).
Prior to that I want to ask if it is OK to add Reported-By or Tested-By similar to what is done
in the Linux kernel. If so, should I use nicknames or real ones (if I know them)? |
|
Back to top |
|
|
Zucca Moderator
Joined: 14 Jun 2007 Posts: 3826 Location: Rasi, Finland
|
Posted: Sat Jan 04, 2025 6:12 pm Post subject: |
|
|
Hi. I tested 9999 version, but the problem persists.
The problem occurs when running lsp inside tmux: Code: | $ echo $TERM; lsp README.adoc
tmux-256color
lsp_init_screen: Could not change color. | While if I'm outside tmux in "raw" foot terminal things work ok. _________________ ..: Zucca :..
My gentoo installs: | init=/sbin/openrc-init
-systemd -logind -elogind seatd |
Quote: | I am NaN! I am a man! |
|
|
Back to top |
|
|
dgouders n00b
Joined: 29 Jan 2024 Posts: 9
|
Posted: Sat Jan 04, 2025 7:37 pm Post subject: |
|
|
Yes, sorry for the confusion.
I didn't commit the color-fixes, because I was waiting for an answer if I am allowed to
give you credit. Anyway, thanks a lot for all the testing!
To stay on the safe side, I now commited the fixes without giving you explicit credit.
So, now your tests should show other results...
Regards,
Dirk |
|
Back to top |
|
|
Zucca Moderator
Joined: 14 Jun 2007 Posts: 3826 Location: Rasi, Finland
|
Posted: Sun Jan 05, 2025 9:51 am Post subject: |
|
|
Ah. Sorry. I read your last post too quickly.
Yes you can credit me if you want, whenever you want. Ilja Sara is the real name.
And your latest fixes did fix the problem. lsp now works on every situation I use it.
It, however, fails with Code: | Error opening terminal: unknown. | if TERM is unset. It should never be unset when using a pager. I just thought to mention, if this is intended behavior. _________________ ..: Zucca :..
My gentoo installs: | init=/sbin/openrc-init
-systemd -logind -elogind seatd |
Quote: | I am NaN! I am a man! |
|
|
Back to top |
|
|
dgouders n00b
Joined: 29 Jan 2024 Posts: 9
|
Posted: Sun Jan 05, 2025 11:17 am Post subject: |
|
|
Zucca wrote: | Ah. Sorry. I read your last post too quickly.
Yes you can credit me if you want, whenever you want. Ilja Sara is the real name.
|
Thank you. Unfortunately the two commits are out but I will do so in the future.
Zucca wrote: |
And your latest fixes did fix the problem. lsp now works on every situation I use it.
It, however, fails with Code: | Error opening terminal: unknown. |
if TERM is unset. It should never be unset when using a pager. I just thought to mention, if this is intended behavior. |
Thanks for the feedback!
Yes, unset TERM shoud be rare cases -- I created an issue so that
this one doesn't get lost.
Regards,
Dirk |
|
Back to top |
|
|
|