Gentoo Forums
Gentoo Forums
Gentoo Forums
Quick Search: in
help me fill bug report? found and fixed a big in package
View unanswered posts
View posts from last 24 hours

 
Reply to topic    Gentoo Forums Forum Index Portage & Programming
View previous topic :: View next topic  
Author Message
picarica
Guru
Guru


Joined: 11 Aug 2018
Posts: 343

PostPosted: Thu Mar 13, 2025 9:40 am    Post subject: help me fill bug report? found and fixed a big in package Reply with quote

hello so i got intel gpu and i needed intel-compute-runtime, couldnt merge newest version so i started digging first i started forum post here with no answers so i asked here and i found the issue

so i just changed
Code:

#from
   >=media-libs/gmmlib-22.5.2:=

#to
   >=media-libs/gmmlib-22.6.0
# also idk why with this reqirement, it download gmmlib 22.7.0 and not 22.6.0, do i not understand ebuild syntax? xd idk

and it merged sucsefully

i filed a bugreport here but i am really bad at those. could anyone help me out push this fix to repo?
Back to top
View user's profile Send private message
John R. Graham
Administrator
Administrator


Joined: 08 Mar 2005
Posts: 10750
Location: Somewhere over Atlanta, Georgia

PostPosted: Thu Mar 13, 2025 12:13 pm    Post subject: Reply with quote

The developers will do the change to the repo for you—and it looks like you got their attention. Good job! Also, your bug report looks fine. One suggestion. It's easier to understand your changes if, rather than posting a new ebuild, you post a patch that produces the new ebuild from the old ebuild. You could create the patch with:
Code:
mkdir -p /tmp/patch/{old,new}
cp old-ebuild-name /tmp/patch/old/intel-compute-runtime-25.05.32567.18.ebuild
cp new-ebuild-name /tmp/patch/new/intel-compute-runtime-25.05.32567.18.ebuild
cd /tmp/patch
diff -ubB old new >intel-compute-runtime-25.05.32567.18.ebuild.patch
of course substituting the correct pathnames for the old and new ebuilds. Sometimes the developers will ask for a patch if you don't provide one.

- John
_________________
I can confirm that I have received between 0 and 499 National Security Letters.
Back to top
View user's profile Send private message
Hu
Administrator
Administrator


Joined: 06 Mar 2007
Posts: 23189

PostPosted: Thu Mar 13, 2025 2:02 pm    Post subject: Reply with quote

picarica wrote:
Code:

#from
   >=media-libs/gmmlib-22.5.2:=

#to
   >=media-libs/gmmlib-22.6.0
# also idk why with this reqirement, it download gmmlib 22.7.0 and not 22.6.0, do i not understand ebuild syntax? xd idk
As of my last sync, the KEYWORDS for gmmlib are:
Code:
media-libs/gmmlib/gmmlib-22.5.5.ebuild:15:    KEYWORDS="amd64"
media-libs/gmmlib/gmmlib-22.6.0.ebuild:15:    KEYWORDS="~amd64"
media-libs/gmmlib/gmmlib-22.7.0.ebuild:15:    KEYWORDS="~amd64"
Thus, users on stable will pick gmmlib-22.5.5, because that is the only stable version. Users on testing could pick 22.6.0, but will pick 22.7.0 because that is higher, and thus "better" when they have the same level of keyword. Your change tells Portage it must use at least 22.6.0, but it can pick any higher version that is not excluded by other rules.
Back to top
View user's profile Send private message
Display posts from previous:   
Reply to topic    Gentoo Forums Forum Index Portage & Programming All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum