| View previous topic :: View next topic |
| Author |
Message |
tld
Veteran
Joined: 09 Dec 2003
Posts: 1846
|
 Posted: Tue Jul 10, 2018 9:10 pm Post subject: Change to paren match in app-editors/vim-8.0.1298 [SOLVED] |
 |
|
The upgrade of vim/gvim/vim-core from 8.0.0386 to 8.0.1298, for something that appeared to be a minor upgrade, has been a source of endless headaches for me. First I ran into the complete breakage of syntax highlighting (mostly in large files), which I was able to work around as discussed here:
https://forums.gentoo.org/viewtopic-t-1083672-highlight-.html
However I just hunted down the old ebuilds and reverted to 8.0.0386 because of an ugly change to the behavior of paren matching. That is, the highlighting of the match for the current parenthesis (or brace etc). I'm seeing this in php and perl files though it may not be limited to those: With the older version that matching highlight would work in things such as SQL or regular expressions embedded in the code. What I'm seeing in the newer version is that the match highlighting seems to be limited to the specific language itself only...as though it's somehow tied specifically to that languages syntax.
I discovered that today when I started working with some complex embedded SQL...wow, not acceptable for sure. Has anyone else noticed this? Hard to believe I'm the only one.
Tom
Last edited by tld on Mon Jul 16, 2018 1:58 pm; edited 2 times in total |
|
| Back to top |
|
 |
Hu
Administrator
Joined: 06 Mar 2007
Posts: 22746
|
| Posted: Wed Jul 11, 2018 2:19 am Post subject: |
|
|
As I understand the Vim versioning convention, that is not as minor an upgrade as you might think. Vim-8.0.0386 is Vim-8.0 with 386 additional patches. Vim-8.0.1298 is Vim-8.0 with 1298 patches. Some of those patches are irrelevant to you (only applicable to non-Linux, or to the self tests, or to features that you might compile out), but that is still a substantial number of patches. If you have the newer Vim installed, you can use :help patch to open the documentation file that summarizes each of the patches. A small sample of the brief summaries: | Code: | Patch 8.0.0386
Problem: Tiny build has a problem with generating the options test.
Solution: Change the "if" to skip over statements.
Files: src/gen_opt_test.vim
Patch 8.0.0387
Problem: compiler warnings
Solution: Add type casts. (Christian Brabandt)
Files: src/channel.c, src/memline.c, |
If you do not have it installed, you can probably find version8.txt somewhere in the source tree and read it that way. |
|
| Back to top |
|
|
tld
Veteran
Joined: 09 Dec 2003
Posts: 1846
|
| Posted: Wed Jul 11, 2018 1:09 pm Post subject: |
|
|
Thanks! Good to know. I logged a bug with them on this one:
https://github.com/vim/vim/issues/3190
I even tried version 8.1.0034 in portage and still have the issue. It seems like paren highlighting in any quoted strings no longer works. I hope that's not by design. |
|
| Back to top |
|
|
tld
Veteran
Joined: 09 Dec 2003
Posts: 1846
|
| Posted: Fri Jul 13, 2018 4:57 pm Post subject: |
|
|
So far no luck with that bug I logged upstream. I'm not sure what's up with that suggested patch, as that doesn't work for me for sure.
If anyone else can verify the behavior I'm seeing that would be a help. To clarify, what's broken is that, within a quoted string in any file, having the cursor on a parenthesis in that string no longer causes the matching paren to be highlighted. Outside of strings, for example in the actual code syntax, the highlighting works. As far as I could tell, the highlighting within quoted strings not only worked in 8.0.0386, but had worked just about forever, even in version 7 and probably earlier.
Also note that this applies to the command line vim and not just to gvim. As noted in that bug, here's a dummy file to illustrate:
| Code: | #!/usr/bin/perl
@a = ('aaa', 'bbb');
$sql = "SELECT (SELECT COUNT(*) FROM sometable)";
$reg = '/^(?:abc|def)$/'; |
With the newer versions, the paren match highlighting only works with my cursor on parens in line two, but not within either of the strings on lines three and four. The first time I tried to edit a file with complex SQL selects embedded in the code as strings without this functionality, I about wanted to cry. No way can/will I do without that.
Tom |
|
| Back to top |
|
|
khayyam
Watchman
Joined: 07 Jun 2012
Posts: 6227
Location: Room 101
|
| Posted: Fri Jul 13, 2018 8:22 pm Post subject: |
|
|
| tld wrote: | | If anyone else can verify the behavior I'm seeing that would be a help. [...] With the newer versions, the paren match highlighting only works with my cursor on parens in line two, but not within either of the strings on lines three and four. |
tld ... I can verify the same behavior here:
| emerge -pvq app-editors/vim: | | [ebuild R ] app-editors/vim-8.0.1298 USE="X acl -cscope -debug -gpm -lua -luajit -minimal -nls -perl -python -racket -ruby (-selinux) -tcl -terminal -vim-pager" PYTHON_SINGLE_TARGET="python3_5 -python2_7 -python3_4 -python3_6" PYTHON_TARGETS="python2_7 -python3_4 -python3_5 -python3_6" |
best ... khay |
|
| Back to top |
|
|
tld
Veteran
Joined: 09 Dec 2003
Posts: 1846
|
| Posted: Fri Jul 13, 2018 9:17 pm Post subject: |
|
|
| Thanks khay! Glad it's not just me. |
|
| Back to top |
|
|
tld
Veteran
Joined: 09 Dec 2003
Posts: 1846
|
| Posted: Sun Jul 15, 2018 4:22 pm Post subject: |
|
|
Looks like this was resolved as of 8.1.0115. Logged a now resolved bug upstream, and this Gentoo bug:
https://bugs.gentoo.org/661254
Tom |
|
| Back to top |
|
|
|
Desktop Environments
