Gentoo Forums
Gentoo Forums
Gentoo Forums
Quick Search: in
Emerging www-client/firefox-66.0.1 on arm64 (patch)
View unanswered posts
View posts from last 24 hours

 
Reply to topic    Gentoo Forums Forum Index Gentoo on ARM
View previous topic :: View next topic  
Author Message
Sakaki
Guru
Guru


Joined: 21 May 2014
Posts: 409

PostPosted: Mon Mar 25, 2019 11:59 pm    Post subject: Emerging www-client/firefox-66.0.1 on arm64 (patch) Reply with quote

Hello,

trying to build the in-tree www-client/firefox-66.0.1 (using gcc) fails on arm64 with the error:
Code:
media/libopus/silk/arm/arm_silk_map.c:31:10: fatal error: 'main_FIX.h' file not
found
 #include "main_FIX.h"

This is Mozilla bug 1530659, which can be fixed with the following patch (adapted trivially from here):
Code:
Author: jbeich <jbeich@FreeBSD.org>
Date: Wed Mar 20 00:19:00 2019
New Revision: 496299
URL: https://svnweb.freebsd.org/changeset/ports/496299

Log:
  www/firefox: unbreak on aarch64 after r495403
 
  media/libopus/silk/arm/arm_silk_map.c:31:10: fatal error: 'main_FIX.h' file not found
   #include "main_FIX.h"
            ^~~~~~~~~~~~
 
  Reported by:  pkg-fallout

Added:
  head/www/firefox/files/patch-bug1530659   (contents, props changed)

Added: head/www/firefox/files/patch-bug1530659

Trivially adapted for use as Gentoo patch by sakaki <sakaki@deciban.com>
==============================================================================
--- a/media/libopus/moz.build
+++ b/media/libopus/moz.build
@@ -63,6 +63,8 @@
     'celt',
     'include',
     'silk',
+    'silk/fixed',
+    'silk/float',
     'src',
 ]
 
@@ -76,15 +78,9 @@
 SOURCES += opus_nonunified_sources
 
 if CONFIG['MOZ_SAMPLE_TYPE_FLOAT32']:
-    LOCAL_INCLUDES += [
-        'silk/float',
-    ]
     UNIFIED_SOURCES += silk_sources_float
     UNIFIED_SOURCES += opus_sources_float
 else:
-    LOCAL_INCLUDES += [
-        'silk/fixed',
-    ]
     UNIFIED_SOURCES += silk_sources_fixed
 
 if CONFIG['CPU_ARCH'] in ('x86', 'x86_64'):


To use, just download the above patch from here, then place it in /etc/portage/patches/www-client/firefox-66.0.1/firefox-66.0.1-fix-libopus-silk-aarch64.patch

Incidentally, a binary package for firefox-66.0.1 has now been pushed to the isshoni.org binhost, for users of my gentoo-on-rpi3-64bit image (and the modified ebuild (which just applies the patch for arm64) may be found here).
_________________
Regards,

sakaki
Back to top
View user's profile Send private message
Khumarahn
Apprentice
Apprentice


Joined: 17 Apr 2009
Posts: 199

PostPosted: Wed Apr 03, 2019 11:12 pm    Post subject: Reply with quote

I don't have this same problem with firefox-66.0.2 on arm64, but it does not compile either.
Here is my (rather large) build.log: https://khu.dedyn.io/firefox-66.0.2-build.log
I completely do not understant what the problem is, the log seems not that informative.
Back to top
View user's profile Send private message
Sakaki
Guru
Guru


Joined: 21 May 2014
Posts: 409

PostPosted: Thu Apr 04, 2019 2:16 am    Post subject: Reply with quote

Khumarahn wrote:
I don't have this same problem with firefox-66.0.2 on arm64, but it does not compile either.
Here is my (rather large) build.log: https://khu.dedyn.io/firefox-66.0.2-build.log
I completely do not understant what the problem is, the log seems not that informative.

I think you do have the same problem - in the build log you attached, lines 5979 ff. read (apologies for the munged unicode / control codes, posting from a phone):
Quote:
7828:06.32 /var/tmp/portage/www-client/firefox-66.0.2/work/firefox-66.0.2/media/libopus/silk/arm/arm_silk_map.c:31:10: fatal error: main_FIX.h: No such file or directory
7828:06.32 #include "main_FIX.h"
7828:06.32 ^~~~~~~~~~~~
7828:06.32 compilation terminated.
7828:06.33 distcc[24087] ERROR: compile /var/tmp/portage/www-client/firefox-66.0.2/work/firefox-66.0.2/media/libopus/silk/arm/arm_silk_map.c on localhost failed
7828:06.33 gmake[4]: *** [/var/tmp/portage/www-client/firefox-66.0.2/work/firefox-66.0.2/config/rules.mk:764: arm_silk_map.o] Error 1

The firefox build process is very parallel, so you often have to look back quite a long way from the end to see what made it fail. Have you tried using the supplied patch? Looks like it should still apply.
_________________
Regards,

sakaki
Back to top
View user's profile Send private message
Khumarahn
Apprentice
Apprentice


Joined: 17 Apr 2009
Posts: 199

PostPosted: Fri Apr 05, 2019 8:08 pm    Post subject: Reply with quote

Thanks a lot, you are right. I could build 66.0.2 with this patch. Will look at chromium soon.
Back to top
View user's profile Send private message
Display posts from previous:   
Reply to topic    Gentoo Forums Forum Index Gentoo on ARM All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum