Question about use flags on a -bin ebuild

[JohnTheCoolingFan]

I have a package from a gentoo-zh overlay, sys-boot/ventoy-bin. The package provides multiple binaries, and as I recently found out, it didn't specify all the runtime dependencies, which caused me to have preserved libraries that couldn't be fixed by a rebuild of sys-boot/ventoy-bin, because the executable files are precompiled. I've submitted a fix for that, specifying the qt dependencies, but I was wondering if maybe it would be ok to conditionally not install the qt5 gui executable based on use flags. I've consulted the Gentoo Development Guide on this: https://devmanual.gentoo.org/general-concepts/use-flags/index.html but I couldn't come to a concrete conclusion. The qt5 GUI excutable comes dynamically linked to qt5 executables. And as far as I can see, there are options for other GUI choices, gtk3 in particular.

So, would it be ok to add such USE flags (qt5, maybe gtk) to this ebuild? Here is the ebuild file: https://github.com/microcai/gentoo-zh/blob/master/sys-boot/ventoy-bin/ventoy-bin-1.0.99.ebuild

The motivation to do this is to allow the user to opt out of runtime dependencies, but it doesn't change how the executables are compiled (since they are pre-compiled and downloaded as source), only which ones are included or not.

[logrusx]

Some time ago chromium ebuild was deleting a library prior to instal if qt flag was not enabled(no qt5/qt6 were present back then), I guess it's OK to do the same.

Best Regards,
Georgi

[JohnTheCoolingFan]

Thanks logrusx! I've submitted the changes to remove the qt5/gtk3 binaries based on use flags, and it was approved. Now I can happily have the program without the qt dependencies I would never use. Nothing personal about qt besides it just feeling less nice, I just have a GNOME system and gtk is preferred. Happy to improve the software I use!