| View previous topic :: View next topic |
| Author |
Message |
eccerr0r
Watchman
Joined: 01 Jul 2004
Posts: 9823
Location: almost Mile High in the USA
|
 Posted: Fri Sep 13, 2024 9:50 pm Post subject: wine-staging-9.15, 17 fails to build due to internal issue? |
 |
|
I don't think this is something the Gentoo devs introduced but wonder if anyone ran across this:
I can't get wine-staging 9.15 or 9.17 to build, it fails:
| Code: | /tmp/portage/app-emulation/wine-staging-9.17/work/wine-staging-9.17/staging/../patches/gitapply.sh -d . < /tmp/portage/app-emulation/wine-staging-9.17/work/wine-staging-9.17/staging/../patches/server-Stored_ACLs/0004-server-Temporarily-store-the-full-security-descripto.patch
patching dlls/advapi32/tests/security.c
1 out of 4 hunks FAILED -- saving rejects to file dlls/advapi32/tests/security.c.rej
[PATCH] ERR: Textual patch did not apply, aborting.
|
Looking at the reject,
| Code: | --- dlls/advapi32/tests/security.c
+++ dlls/advapi32/tests/security.c
@@ -3906,7 +3904,6 @@ static void test_CreateDirectoryA(void)
ok(error == ERROR_SUCCESS, "GetNamedSecurityInfo failed with error %d\n", error);
bret = GetAclInformation(pDacl, &acl_size, sizeof(acl_size), AclSizeInformation);
ok(bret, "GetAclInformation failed\n");
- todo_wine
ok(acl_size.AceCount == 0, "GetAclInformation returned unexpected entry count (%ld != 0).\n",
acl_size.AceCount);
LocalFree(pSD);
|
which came from within the wine-staging patches...
9.15 has a similar or same issue just different version...
Is this an environment or packaging issue by upstream? Anyone else seeing this failure? This is highly odd that multiple wine-staging packages fail the same way...
_________________
Intel Core i7 2700K/Radeon R7 250/24GB DDR3/256GB SSD
What am I supposed watching? |
|
| Back to top |
|
 |
Ionen
Developer
Joined: 06 Dec 2018
Posts: 2851
|
| Posted: Fri Sep 13, 2024 10:15 pm Post subject: |
|
|
I think the fallback may have broke, by default it uses dev-vcs/git to apply patches, but if missing it tries to use other tools (the ebuild currently allows this but I never test that).
tl;dr install dev-vcs/git, I'll probably kill the fallback if it's going to be flaky |
|
| Back to top |
|
|
Ionen
Developer
Joined: 06 Dec 2018
Posts: 2851
|
|
| Back to top |
|
|
eccerr0r
Watchman
Joined: 01 Jul 2004
Posts: 9823
Location: almost Mile High in the USA
|
| Posted: Fri Sep 13, 2024 10:45 pm Post subject: |
|
|
I worked-around using wine-vanilla as it appears to have pulled in the staging changes needed but thanks, will have to look into that. I thought I had git installed on most machines but maybe not that one ...
_________________
Intel Core i7 2700K/Radeon R7 250/24GB DDR3/256GB SSD
What am I supposed watching? |
|
| Back to top |
|
|
eccerr0r
Watchman
Joined: 01 Jul 2004
Posts: 9823
Location: almost Mile High in the USA
|
| Posted: Sat Sep 21, 2024 12:36 pm Post subject: |
|
|
hmm so now wine-staging-* will always be checking out a copy of patches from git? A specific version hopefully?
What's the point of the packaged patches now?
_________________
Intel Core i7 2700K/Radeon R7 250/24GB DDR3/256GB SSD
What am I supposed watching? |
|
| Back to top |
|
|
Ionen
Developer
Joined: 06 Dec 2018
Posts: 2851
|
| Posted: Sat Sep 21, 2024 1:24 pm Post subject: |
|
|
| eccerr0r wrote: | hmm so now wine-staging-* will always be checking out a copy of patches from git? A specific version hopefully?
What's the point of the packaged patches now? |
No, it uses git to apply the patches included in the tarball given it can't use /usr/bin/patch for some binary patches. Thus needing hacks to apply them when git is missing, it's not checking out anything unless using the live 9999 ebuild. |
|
| Back to top |
|
|
|
Portage & Programming
