| View previous topic :: View next topic |
| Author |
Message |
pjp
Administrator
Joined: 16 Apr 2002
Posts: 20496
|
 Posted: Fri Sep 06, 2002 11:10 pm Post subject: "View posts since last visit" request |
 |
|
Would it be unmaintainable to add a "Mark all forums read" link/button to the pages viewed after clicking on "View posts since last visit?
_________________
Quis separabit? Quo animo? |
|
| Back to top |
|
 |
Scandium
Retired Dev
Joined: 22 Apr 2002
Posts: 340
Location: Germany
|
| Posted: Sun Sep 08, 2002 7:35 pm Post subject: |
|
|
*nod*
what a great idea  |
|
| Back to top |
|
|
klieber
Bodhisattva
Joined: 17 Apr 2002
Posts: 3657
Location: San Francisco, CA
|
| Posted: Sun Sep 08, 2002 7:51 pm Post subject: |
|
|
Submit a patch and I'll look at it. Off the top of my head, my guess is you'd need to modify /templates/search_body.tpl to include the necessary link.
As an alternative, you could just bookmark the following link:
https://forums.gentoo.org/index.php?mark=forums
--kurt
_________________
The problem with political jokes is that they get elected |
|
| Back to top |
|
|
pjp
Administrator
Joined: 16 Apr 2002
Posts: 20496
|
| Posted: Tue Sep 10, 2002 4:16 am Post subject: |
|
|
I find it a bit amusing tha Gentoo Forums use phpbb and there is no ebuild for it 
_________________
Quis separabit? Quo animo? |
|
| Back to top |
|
|
Scandium
Retired Dev
Joined: 22 Apr 2002
Posts: 340
Location: Germany
|
| Posted: Tue Sep 10, 2002 12:03 pm Post subject: |
|
|
| kanuslupus wrote: | | I find it a bit amusing tha Gentoo Forums use phpbb and there is no ebuild for it |
In general I heavily doubt the usefullness of things like phpbb, postnuke, phpnuke etc. becoming ebuild'ed...
You only need to extract them into your webhome and open the setup script in your browser...However, I read things like PHPNuke etc. won't get ebuild'ed and that's good |
|
| Back to top |
|
|
dioxmat
Bodhisattva
Joined: 04 May 2002
Posts: 709
Location: /home/mat
|
| Posted: Tue Sep 10, 2002 12:21 pm Post subject: |
|
|
kanusplusplus : where do you want the link to be *exactly* ?
I can work on a patch if you tell me what is exaclty needed... |
|
| Back to top |
|
|
pjp
Administrator
Joined: 16 Apr 2002
Posts: 20496
|
| Posted: Tue Sep 10, 2002 5:05 pm Post subject: |
|
|
Sent a PM.
_________________
Quis separabit? Quo animo? |
|
| Back to top |
|
|
Scandium
Retired Dev
Joined: 22 Apr 2002
Posts: 340
Location: Germany
|
| Posted: Tue Sep 10, 2002 11:27 pm Post subject: |
|
|
| I am the only non-moderator posting in this thread...*feeling strange* |
|
| Back to top |
|
|
Chickpea
l33t
Joined: 03 Jun 2002
Posts: 846
Location: Vancouver WA
|
| Posted: Tue Sep 10, 2002 11:34 pm Post subject: |
|
|
I was thinking the same thing the other day. It would be very nice to mark "all forums read" much easier than clicking each forum.
Now, Scandium, you wont be the only non-moderator posting to this thread feel less strange yet?
C |
|
| Back to top |
|
|
klieber
Bodhisattva
Joined: 17 Apr 2002
Posts: 3657
Location: San Francisco, CA
|
| Posted: Wed Sep 11, 2002 12:05 am Post subject: |
|
|
| Chickpea wrote: | | I was thinking the same thing the other day. It would be very nice to mark "all forums read" much easier than clicking each forum. |
just to clarify -- you can currently do that on the main page. There's a link in the bottom left corner of the home page that says "Mark all forums read". That link, however, is not on the "view posts since last visit" page, which I believe is the one that kanuslupus was referring to.
--kurt
_________________
The problem with political jokes is that they get elected |
|
| Back to top |
|
|
pjp
Administrator
Joined: 16 Apr 2002
Posts: 20496
|
| Posted: Wed Sep 11, 2002 12:12 am Post subject: |
|
|
| klieber wrote: | | That link, however, is not on the "view posts since last visit" page, which I believe is the one that kanuslupus was referring to. |
You are correct sir. [/Ed McMahon]
_________________
Quis separabit? Quo animo? |
|
| Back to top |
|
|
rac
Bodhisattva
Joined: 30 May 2002
Posts: 6553
Location: Japanifornia
|
|
| Back to top |
|
|
pjp
Administrator
Joined: 16 Apr 2002
Posts: 20496
|
| Posted: Wed Sep 11, 2002 12:17 am Post subject: |
|
|
*cough**cough*
I'd prefer the 'high-tech' solution if it proves to not be a hassle to maintain.
_________________
Quis separabit? Quo animo? |
|
| Back to top |
|
|
rac
Bodhisattva
Joined: 30 May 2002
Posts: 6553
Location: Japanifornia
|
| Posted: Wed Sep 11, 2002 12:42 am Post subject: |
|
|
As an attempt to atone for that rather pointless effort, | Code: | --- includes/page_header.php.orig Sat Aug 17 14:10:11 2002
+++ includes/page_header.php Wed Sep 11 09:42:02 2002
@@ -349,6 +349,7 @@
'L_LOG_ME_IN' => $lang['Log_me_in'],
'L_AUTO_LOGIN' => $lang['Log_me_in'],
'L_INDEX' => sprintf($lang['Forum_Index'], $board_config['sitename']),
+ 'L_MARK_FORUMS_READ' => $lang['Mark_all_forums'],
'L_REGISTER' => $lang['Register'],
'L_PROFILE' => $lang['Profile'],
'L_SEARCH' => $lang['Search'],
@@ -371,6 +372,7 @@
'U_SEARCH_SELF' => append_sid('search.'.$phpEx.'?search_id=egosearch'),
'U_SEARCH_NEW' => append_sid('search.'.$phpEx.'?search_id=newposts'),
'U_INDEX' => append_sid('index.'.$phpEx),
+ 'U_MARK_READ' => append_sid("index.$phpEx?mark=forums"),
'U_REGISTER' => append_sid('profile.'.$phpEx.'?mode=register'),
'U_PROFILE' => append_sid('profile.'.$phpEx.'?mode=editprofile'),
'U_PRIVATEMSGS' => append_sid('privmsg.'.$phpEx.'?folder=inbox'),
--- templates/subSilver/search_results_topics.tpl.orig Wed Sep 11 09:32:21 2002
+++ templates/subSilver/search_results_topics.tpl Wed Sep 11 09:33:25 2002
@@ -11,6 +11,12 @@
</tr>
</table>
+<table width="100%" cellspacing="2" cellpadding="2" border="0" align="center">
+ <tr>
+ <td align="left"><span class="gensmall"><a href="{U_MARK_READ}" class="gensmall">{L_MARK_FORUMS_READ}</a></span></td>
+ </tr>
+</table>
+
<table width="100%" cellpadding="4" cellspacing="1" border="0" class="forumline" align="center">
<tr>
<th width="4%" height="25" class="thCornerL" nowrap="nowrap"> </th> |
...this places it in the same style as the link on the index page, directly under the other index link on the search result page. Note that this makes this link appear on all search result pages where threads are returned, not just the newposts.
_________________
For every higher wall, there is a taller ladder |
|
| Back to top |
|
|
pjp
Administrator
Joined: 16 Apr 2002
Posts: 20496
|
| Posted: Wed Sep 11, 2002 1:22 am Post subject: |
|
|
Wow. That looks alot more complicated than I'd expected.
_________________
Quis separabit? Quo animo? |
|
| Back to top |
|
|
slais-sysweb
Apprentice
Joined: 14 Jun 2002
Posts: 221
Location: London
|
| Posted: Wed Sep 11, 2002 3:00 pm Post subject: |
|
|
Why do you need this? If you logon then go view posts since last vist, logoff and logon again view posts since last vist will be clear.
_________________
--
djc
sysweb SLAIS UCL |
|
| Back to top |
|
|
klieber
Bodhisattva
Joined: 17 Apr 2002
Posts: 3657
Location: San Francisco, CA
|
| Posted: Wed Sep 11, 2002 3:03 pm Post subject: |
|
|
| slais-sysweb wrote: | | Why do you need this? If you logon then go view posts since last vist, logoff and logon again view posts since last vist will be clear. |
I think it's more of an ease-of-use thing.
--kurt
_________________
The problem with political jokes is that they get elected |
|
| Back to top |
|
|
pjp
Administrator
Joined: 16 Apr 2002
Posts: 20496
|
| Posted: Wed Sep 11, 2002 4:53 pm Post subject: |
|
|
Exactly. I'd like a feature, not a hack or workaround.
_________________
Quis separabit? Quo animo? |
|
| Back to top |
|
|
klieber
Bodhisattva
Joined: 17 Apr 2002
Posts: 3657
Location: San Francisco, CA
|
| Posted: Thu Sep 12, 2002 1:36 am Post subject: |
|
|
I haven't forgotten about the patch -- I just got caught up in my httptunnel init script tonight along with trying to figure out why I couldn't get httptunnel to work in the first place (duh, because you had the port blocked on the firewall you idiot...) So, I'll get to this tomorrow night...
--kurt
_________________
The problem with political jokes is that they get elected |
|
| Back to top |
|
|
rac
Bodhisattva
Joined: 30 May 2002
Posts: 6553
Location: Japanifornia
|
| Posted: Thu Sep 12, 2002 2:04 am Post subject: |
|
|
OK, hang on a bit, because I may rework it to make it look like kanuslupus wants it to. BTW, kanuslupus, could you post your opinion about how it should look to this thread?
_________________
For every higher wall, there is a taller ladder |
|
| Back to top |
|
|
pjp
Administrator
Joined: 16 Apr 2002
Posts: 20496
|
| Posted: Thu Sep 12, 2002 3:03 am Post subject: |
|
|
Here's what I sent to dioxmat for what I was wanting to achieve.
See this link for reference. You should see "Search found x matches". Under that, "Gentoo Forums Forum Index". I was going to try to position the "Mark all forums read" link opposite "Gentoo Forums Forum Index". As an example, where "View unanswered posts" is on the main page. In addition, I was going to add one to the bottom of the page on the left side (Under "Page 1 of x" if that is visible). Does that make sense?
The basic idea being to get the "Mark all forums read" link in 2 convenient locations... 1 at the top, the other near the bottom. Those two locations just seemed the best to me.
_________________
Quis separabit? Quo animo? |
|
| Back to top |
|
|
rac
Bodhisattva
Joined: 30 May 2002
Posts: 6553
Location: Japanifornia
|
| Posted: Thu Sep 12, 2002 5:25 am Post subject: |
|
|
OK, here's version 2, which was emailed to klieber as well: | Code: | --- includes/page_header.php.orig Sat Aug 17 14:10:11 2002
+++ includes/page_header.php Wed Sep 11 09:42:02 2002
@@ -349,6 +349,7 @@
'L_LOG_ME_IN' => $lang['Log_me_in'],
'L_AUTO_LOGIN' => $lang['Log_me_in'],
'L_INDEX' => sprintf($lang['Forum_Index'], $board_config['sitename']),
+ 'L_MARK_FORUMS_READ' => $lang['Mark_all_forums'],
'L_REGISTER' => $lang['Register'],
'L_PROFILE' => $lang['Profile'],
'L_SEARCH' => $lang['Search'],
@@ -371,6 +372,7 @@
'U_SEARCH_SELF' => append_sid('search.'.$phpEx.'?search_id=egosearch'),
'U_SEARCH_NEW' => append_sid('search.'.$phpEx.'?search_id=newposts'),
'U_INDEX' => append_sid('index.'.$phpEx),
+ 'U_MARK_READ' => append_sid("index.$phpEx?mark=forums"),
'U_REGISTER' => append_sid('profile.'.$phpEx.'?mode=register'),
'U_PROFILE' => append_sid('profile.'.$phpEx.'?mode=editprofile'),
'U_PRIVATEMSGS' => append_sid('privmsg.'.$phpEx.'?folder=inbox'),
--- templates/subSilver/search_results_topics.tpl.orig Wed Sep 11 09:32:21 2002
+++ templates/subSilver/search_results_topics.tpl Thu Sep 12 14:19:47 2002
@@ -8,6 +8,7 @@
<table width="100%" cellspacing="2" cellpadding="2" border="0" align="center">
<tr>
<td align="left"><span class="nav"><a href="{U_INDEX}" class="nav">{L_IN
DEX}</a></span></td>
+ <td align="right"><span class="gensmall"><a href="{U_MARK_READ}" class="
gensmall">{L_MARK_FORUMS_READ}</a></span></td>
</tr>
</table>
@@ -41,6 +42,9 @@
<tr>
<td align="left" valign="top"><span class="nav">{PAGE_NUMBER}</span></td
>
<td align="right" valign="top" nowrap="nowrap"><span class="nav">{PAGINA
TION}</span><br /><span class="gensmall">{S_TIMEZONE}</span></td>
+ </tr>
+ <tr>
+ <td align="left"><span class="gensmall"><a href="{U_MARK_READ}" class="g
ensmall">{L_MARK_FORUMS_READ}</a></span></td>
</tr>
</table>
|
_________________
For every higher wall, there is a taller ladder |
|
| Back to top |
|
|
klieber
Bodhisattva
Joined: 17 Apr 2002
Posts: 3657
Location: San Francisco, CA
|
| Posted: Mon Sep 16, 2002 1:10 pm Post subject: |
|
|
BTW, this should be implemented now, in case you hadn't already figured that out.
Thanks to rac for doing the grunt work.
--kurt
_________________
The problem with political jokes is that they get elected |
|
| Back to top |
|
|
pjp
Administrator
Joined: 16 Apr 2002
Posts: 20496
|
| Posted: Mon Sep 16, 2002 3:14 pm Post subject: |
|
|
Oh, well, nevermind. I don't need it anymore, I just bookmarked it. 
Just kidding. Thanks all.
_________________
Quis separabit? Quo animo? |
|
| Back to top |
|
|
pjp
Administrator
Joined: 16 Apr 2002
Posts: 20496
|
| Posted: Mon Sep 16, 2002 4:07 pm Post subject: |
|
|
Just had to add that I really, like this addition.
_________________
Quis separabit? Quo animo? |
|
| Back to top |
|
|
|
Gentoo Forums Feedback
