View previous topic :: View next topic |
Author |
Message |
Nuteater Apprentice
Joined: 25 Sep 2003 Posts: 193 Location: Jyväskylä, Finland
|
Posted: Wed Jul 27, 2005 2:32 pm Post subject: |
|
|
It's good that someone is continuing the good work the torsmo developers
started.
If feature requests are welcome, the final feature I would like so that I could
ditch gkrellm for good is a scrolling histogram-like display of cpu, disk and
bandwidth usage. Sometimes just seeing the current usage is not informative
enough, and seeing the big picture requires to see the recent history as well.
That, and allowing conky being seen through transparent windows would make
my beautiful, minimalistic desktop complete , but as mentioned before,
this is probably a xorg issue. _________________ I am Nuteater, hear me roar. |
|
Back to top |
|
|
brenden l33t
Joined: 09 Mar 2004 Posts: 710 Location: Calgary, AB
|
Posted: Wed Jul 27, 2005 3:52 pm Post subject: |
|
|
Nuteater wrote: | It's good that someone is continuing the good work the torsmo developers
started.
If feature requests are welcome, the final feature I would like so that I could
ditch gkrellm for good is a scrolling histogram-like display of cpu, disk and
bandwidth usage. Sometimes just seeing the current usage is not informative
enough, and seeing the big picture requires to see the recent history as well.
That, and allowing conky being seen through transparent windows would make
my beautiful, minimalistic desktop complete , but as mentioned before,
this is probably a xorg issue. |
This is something I already plan on doing, hopefully this weekend. |
|
Back to top |
|
|
jack_mort Apprentice
Joined: 30 Jan 2003 Posts: 167
|
Posted: Wed Jul 27, 2005 4:55 pm Post subject: |
|
|
brenden wrote: | Your logic is correct, but the syntax is wrong. I changed it to:
Code: | if (strstr(s, "UTF-8") || strstr(s, "utf-8")) |
Thanks for pointing this out. |
Hummm... maybe you should also add "utf8" (and why not UTF8 ) in the test, as my locale -a output shows me locales with utf8 and not UTF-8 or utf-8 |
|
Back to top |
|
|
ndreas n00b
Joined: 02 Jul 2002 Posts: 36 Location: Gothenburg, Sweden
|
Posted: Wed Jul 27, 2005 5:24 pm Post subject: |
|
|
A small feature request...
It would be nice if the MPD features could include total time, elapsed time and maybe remaining time for the currently playing song. For me, the bar is not quite enough (50% of what, 2 minutes or 10?). I could probably implement it myself but I would need time, which I really don't have, to get familiar with the code, and I suspect it is not that big an addition.
Ditching the once-a-second-executed mpc would be sweeet
Very nice work, by the way. |
|
Back to top |
|
|
Meqif Tux's lil' helper
Joined: 09 Mar 2003 Posts: 103 Location: Portugal
|
Posted: Wed Jul 27, 2005 7:00 pm Post subject: |
|
|
jack_mort wrote: | brenden wrote: | Your logic is correct, but the syntax is wrong. I changed it to:
Code: | if (strstr(s, "UTF-8") || strstr(s, "utf-8")) |
Thanks for pointing this out. |
Hummm... maybe you should also add "utf8" (and why not UTF8 ) in the test, as my locale -a output shows me locales with utf8 and not UTF-8 or utf-8 |
Seconded: I added utf8, not utf-8, for the same reason. |
|
Back to top |
|
|
brenden l33t
Joined: 09 Mar 2004 Posts: 710 Location: Calgary, AB
|
Posted: Wed Jul 27, 2005 11:53 pm Post subject: |
|
|
yos0n wrote: | A small feature request...
It would be nice if the MPD features could include total time, elapsed time and maybe remaining time for the currently playing song. For me, the bar is not quite enough (50% of what, 2 minutes or 10?). I could probably implement it myself but I would need time, which I really don't have, to get familiar with the code, and I suspect it is not that big an addition.
Ditching the once-a-second-executed mpc would be sweeet
Very nice work, by the way. |
This is something I probably should have already done, but I'm lazy. |
|
Back to top |
|
|
Finkregh n00b
Joined: 28 Jul 2005 Posts: 3
|
|
Back to top |
|
|
brenden l33t
Joined: 09 Mar 2004 Posts: 710 Location: Calgary, AB
|
Posted: Thu Jul 28, 2005 1:44 am Post subject: |
|
|
Looks great for the most part. One thing I noticed, however, is that you have some ${exec ps} thing. As of conky 1.1, this functionality is built into conky via the ${top}, and as of 1.2 ${top_mem}. I'd suggest using that, since it's significantly faster. Also, although I don't know anything other then English, seeing "mv conky /usr/local/bin" made me a little vervous. This should be done via "make install". |
|
Back to top |
|
|
Finkregh n00b
Joined: 28 Jul 2005 Posts: 3
|
Posted: Thu Jul 28, 2005 2:20 am Post subject: |
|
|
well thx so far, ill read it again tomorrow
in germany it is 04:00 in the morning... soo... maybe i didnt "make install" because of that...
stab me writing such a text when i am so tired :> |
|
Back to top |
|
|
elektronisch n00b
Joined: 08 Dec 2004 Posts: 12
|
Posted: Thu Jul 28, 2005 2:50 am Post subject: |
|
|
brenden wrote: | Meqif wrote: | The latest cvs revision isn't displaying utf8 properly, it reverted to the old behavior.
EDIT: It's related to the detection of utf8 in the environment. I forced utf8 by changing "int utf8_mode = 0;" to "int utf8_mode = 1;" and it works perfectly.
EDIT2: Changing just Code: | if (strstr(s, "UTF-8")) | to Code: | if (strstr(s, "UTF-8")||(s, "utf8")) | solves it without having to mess with the utf8_mode in the beginning. I know my fix isn't properly coded but my programming knowledge is near null.
Code: | meqif@envy:: locale -a|grep UTF
meqif@envy:: locale -a|grep utf
en_US.utf8
pt_PT.utf8
|
Now you know why I fixed the problem this way. |
Your logic is correct, but the syntax is wrong. I changed it to:
Code: | if (strstr(s, "UTF-8") || strstr(s, "utf-8")) |
Thanks for pointing this out. |
you're syntax is correct except its utf8 instead of utf-8 _________________ Slackware user, but for some reason I'm here. |
|
Back to top |
|
|
brenden l33t
Joined: 09 Mar 2004 Posts: 710 Location: Calgary, AB
|
Posted: Thu Jul 28, 2005 3:31 am Post subject: |
|
|
elektronisch wrote: | you're syntax is correct except its utf8 instead of utf-8 |
Yeah, I'll make it check for everything. My locale returns:
so that is what I was going by.
I did this (which will hopefully keep everything & everyone happy):
Code: | if (strstr(s, "UTF-8") || strstr(s, "utf-8") || strstr(s, "UTF8") || strstr(s, "utf8")) |
Last edited by brenden on Thu Jul 28, 2005 3:37 am; edited 1 time in total |
|
Back to top |
|
|
brenden l33t
Joined: 09 Mar 2004 Posts: 710 Location: Calgary, AB
|
Posted: Thu Jul 28, 2005 3:33 am Post subject: |
|
|
Finkregh wrote: | well thx so far, ill read it again tomorrow
in germany it is 04:00 in the morning... soo... maybe i didnt "make install" because of that...
stab me writing such a text when i am so tired :> |
Thanks a lot for the contribution. It's great when people help the project out. I just wanted to give you my thoughts. |
|
Back to top |
|
|
elektronisch n00b
Joined: 08 Dec 2004 Posts: 12
|
Posted: Thu Jul 28, 2005 4:34 am Post subject: |
|
|
Just a suggestion..
use strcasecmp so you dont have to clutter it all up by checking a string for different case variations.
Example:
if(strcasecmp(s, "utf8") == 0 || strcasecmp(s, "utf-8") == 0 )) {
}
P.s, how do I contribute to this project besides going through you? Is there a way I can submit changes to a repository? This project seems fun _________________ Slackware user, but for some reason I'm here. |
|
Back to top |
|
|
brenden l33t
Joined: 09 Mar 2004 Posts: 710 Location: Calgary, AB
|
Posted: Thu Jul 28, 2005 4:46 am Post subject: |
|
|
elektronisch wrote: | Just a suggestion..
use strcasecmp so you dont have to clutter it all up by checking a string for different case variations.
Example:
if(strcasecmp(s, "utf8") == 0 || strcasecmp(s, "utf-8") == 0 )) {
}
P.s, how do I contribute to this project besides going through you? Is there a way I can submit changes to a repository? This project seems fun |
Register on sf.net and email me your sf.net account username. I will happily give you cvs access.
strcasecmp won't work, since there is other stuff in the string. Another option is tolower'ing the string first, but I didn't feel like mucking with it. Feel free to have at it. I'm currently working on creating the special scrolling graph object. |
|
Back to top |
|
|
ryanc n00b
Joined: 19 May 2003 Posts: 2
|
Posted: Thu Jul 28, 2005 4:02 pm Post subject: |
|
|
the last version of torsmo had a feature for displaying your current CPU freqeuence a la $freq. Was Conky
a fork from that version and does it (Conky) still have that feature?
i didn't notice it in the README but I tend to be blind sometimes :)
later.
ryanc |
|
Back to top |
|
|
Finkregh n00b
Joined: 28 Jul 2005 Posts: 3
|
Posted: Thu Jul 28, 2005 4:05 pm Post subject: |
|
|
well a far as i know.. yes ^^ |
|
Back to top |
|
|
brenden l33t
Joined: 09 Mar 2004 Posts: 710 Location: Calgary, AB
|
Posted: Thu Jul 28, 2005 4:41 pm Post subject: |
|
|
ryanc wrote: | the last version of torsmo had a feature for displaying your current CPU freqeuence a la $freq. Was Conky
a fork from that version and does it (Conky) still have that feature?
i didn't notice it in the README but I tend to be blind sometimes
later.
ryanc |
Yes, you can use $freq to get the cpu frequency |
|
Back to top |
|
|
jack_mort Apprentice
Joined: 30 Jan 2003 Posts: 167
|
Posted: Thu Jul 28, 2005 7:24 pm Post subject: |
|
|
I've just updated with the cvs code, and it's quite unusable : there's too much space drawn between lines, making the last ones not to be displayed... maybe you made some changes in text height while introducing graphs ? |
|
Back to top |
|
|
elektronisch n00b
Joined: 08 Dec 2004 Posts: 12
|
Posted: Thu Jul 28, 2005 8:37 pm Post subject: Sent you a message on sf.net |
|
|
Sent you a message on sf.net.
Also, what editor are you using? The formatting near the bottom of conky.c is completely screwed up.
Thanks,
Jay _________________ Slackware user, but for some reason I'm here. |
|
Back to top |
|
|
brenden l33t
Joined: 09 Mar 2004 Posts: 710 Location: Calgary, AB
|
Posted: Fri Jul 29, 2005 1:26 am Post subject: |
|
|
jack_mort wrote: | I've just updated with the cvs code, and it's quite unusable : there's too much space drawn between lines, making the last ones not to be displayed... maybe you made some changes in text height while introducing graphs ? |
Yes, I did make some changes. I didn't notice this when I was initially testing it, but the code is probably quite buggy. |
|
Back to top |
|
|
brenden l33t
Joined: 09 Mar 2004 Posts: 710 Location: Calgary, AB
|
Posted: Fri Jul 29, 2005 1:27 am Post subject: Re: Sent you a message on sf.net |
|
|
elektronisch wrote: | Sent you a message on sf.net.
Also, what editor are you using? The formatting near the bottom of conky.c is completely screwed up.
Thanks,
Jay |
This has to do with some of the macros in conky.c. Most editors (as well as indent) don't know what to do about it. I gave up messing with it. I don't feel like expanding the macros just to make the indentation look nice. |
|
Back to top |
|
|
ashtophet Guru
Joined: 08 Aug 2004 Posts: 397
|
Posted: Sat Jul 30, 2005 6:51 am Post subject: |
|
|
I've just discovered conky a few days ago and i only can thank you for yr. great work!
I use the built-in mpd options, but i listen to a lot of music with characters such as "ção", "à"... With the little script that i called from torsmo they are displayed correctly, but with conky built-in, they are not. Is there any workaround?
cheers
Edit. Oops, forgot it: i am using the (by now) latest CVS. |
|
Back to top |
|
|
brenden l33t
Joined: 09 Mar 2004 Posts: 710 Location: Calgary, AB
|
Posted: Sat Jul 30, 2005 7:02 am Post subject: |
|
|
galiza_ceive wrote: | I've just discovered conky a few days ago and i only can thank you for yr. great work!
I use the built-in mpd options, but i listen to a lot of music with characters such as "ção", "à"... With the little script that i called from torsmo they are displayed correctly, but with conky built-in, they are not. Is there any workaround?
cheers
Edit. Oops, forgot it: i am using the (by now) latest CVS. |
Hmm...the latest conky (CVS) has support for UTF-8 characters. I've tested with mpd and special characters, and it seems okay. Are your locale settings proper? (ie locale -a) and are you using XFT?
XFT is needed to use UTF-8. |
|
Back to top |
|
|
ashtophet Guru
Joined: 08 Aug 2004 Posts: 397
|
Posted: Sat Jul 30, 2005 7:09 am Post subject: |
|
|
I don't use UTF8 as locale (pt_PT@euro), and yes i am using xft.
With this locale configuration the script i used in tormo shows correctly the titles...
thanks |
|
Back to top |
|
|
brenden l33t
Joined: 09 Mar 2004 Posts: 710 Location: Calgary, AB
|
Posted: Sat Jul 30, 2005 7:18 am Post subject: |
|
|
galiza_ceive wrote: | I don't use UTF8 as locale (pt_PT@euro), and yes i am using xft.
With this locale configuration the script i used in tormo shows correctly the titles...
thanks |
I can add an "override_utf8_locale" option to the config, or something of the sort. This might solve your issue. |
|
Back to top |
|
|
|