| View previous topic :: View next topic |
| Author |
Message |
Shining Arcanine
Veteran
Joined: 24 Sep 2009
Posts: 1110
|
 Posted: Sun May 23, 2010 7:28 pm Post subject: Tackling bug #320875 |
 |
|
I found the following bug a few days ago:
https://bugs.gentoo.org/show_bug.cgi?id=320875
To fix it, I want to patch ConsoleKit to use FirstLetterCaps-style names. There seem to be two ways of doing this. The first is to do a simple find and replace for each of the affected names in the source files, generate patch files from that and then modify the ebuild to apply the patches. The second is to modify the ebuild do a find and replace on the source.
Does anyone have an opinion on which approach is better? |
|
| Back to top |
|
 |
skellr
l33t
Joined: 18 Jun 2005
Posts: 976
Location: The Village, Portmeirion
|
| Posted: Sun May 23, 2010 8:33 pm Post subject: |
|
|
| I'm pretty sure they would prefer a patch for this. |
|
| Back to top |
|
|
Shining Arcanine
Veteran
Joined: 24 Sep 2009
Posts: 1110
|
| Posted: Mon May 24, 2010 12:58 am Post subject: |
|
|
| skellr wrote: | | I'm pretty sure they would prefer a patch for this. |
Thanks for your opinion. I thought about how to patch ConsoleKit to change its member names, but there were so many places that needed to be patched and there was a possibility that other software relied on those names, so I decided to patch Qt-Dbus instead. Qt-Dbus is amazingly well written, so it is very easy for me to figure out what I had to change. It seems that I only had to patch a single line of code to fix this bug. 
I am going to post my patch and a modified ebuild in the bug report. |
|
| Back to top |
|
|
skellr
l33t
Joined: 18 Jun 2005
Posts: 976
Location: The Village, Portmeirion
|
| Posted: Mon May 24, 2010 1:36 am Post subject: |
|
|
| Good to hear there was another way to get it done. Hope it gets committed upstream. |
|
| Back to top |
|
|
Shining Arcanine
Veteran
Joined: 24 Sep 2009
Posts: 1110
|
| Posted: Mon May 24, 2010 1:40 am Post subject: |
|
|
| skellr wrote: | | Good to hear there was another way to get it done. Hope it gets committed upstream. |
I do too. I sent the patch to upstream:
http://bugreports.qt.nokia.com/browse/QTBUG-10927
The first way I tried was a workaround for the issue that was suggested on ConsoleKit's bug tracker, but it was never adopted, likely for the reasons I said above. This way solves the actual problem. |
|
| Back to top |
|
|
|
Other Things Gentoo
